PreparedLayout -> PreparedTextLayout#55558
Open
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Open
PreparedLayout -> PreparedTextLayout#55558NickGerleman wants to merge 1 commit intofacebook:mainfrom
NickGerleman wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93381797. |
Summary: `PreparedLayout`, in the Android context, refers to an `android.text.Layout`, but is ambiguous, outside of areas which are not clearly namespaced. Lets rename these instances to `PreparedTextLayout`, which also better matches the feature flag name, `enablePreparedTextLayout`, and the Android view `PreparedLayoutTextView`. Changelog: [Internal] Differential Revision: D93381797
eb87450 to
804d5eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
PreparedLayout, in the Android context, refers to anandroid.text.Layout, but is ambiguous, outside of areas which are not clearly namespaced. Lets rename these instances toPreparedTextLayout, which also better matches the feature flag name,enablePreparedTextLayout, and the Android viewPreparedLayoutTextView.Changelog: [Internal]
Differential Revision: D93381797